fix: terminate unavailable input stream publishers once - #13
Closed
Vikram-Lex wants to merge 1 commit into
Closed
Conversation
Owner
|
Close since it seems agent spam. Reopen only if you're not a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
BodyPublishers.ofInputStreamreceives a supplier that returnsnull, it subscribes to an empty publisher before reportingIOException. Positive demand can therefore produce both completion and failure; invalid demand can produce two errors, and cancellation duringonSubscribeis ignored.Use a failed subscription with one atomic terminal state so cancellation, invalid demand, and the unavailable-stream error cannot produce conflicting callbacks. Add four public-API regression cases shared with the JVM tests. They record callbacks and check them from the test thread, which catches extra terminal signals that assertions inside worker callbacks can miss.
Validation on macOS arm64 (Scala 3.3.7 / Scala Native 0.5.12 / JVM 25):
42ac91b4.This contributes to the JVM-parity work discussed in Requests-Scala #156. Would a US$25 reward be available for this fix and its tests?